Fix 29 audit findings across all severity tiers

src/core/appstream.rs

@@ -405,7 +405,6 @@ fn summarize_content_rating(attrs: &[(String, String)]) -> String {
 // AppStream catalog generation - writes catalog XML for GNOME Software/Discover
 // ---------------------------------------------------------------------------
 
-#[allow(dead_code)]
 /// Generate an AppStream catalog XML from the Driftwood database.
 /// This allows GNOME Software / KDE Discover to see locally managed AppImages.
 pub fn generate_catalog(db: &Database) -> Result<String, AppStreamError> {
@@ -463,7 +462,6 @@ pub fn generate_catalog(db: &Database) -> Result<String, AppStreamError> {
     Ok(xml)
 }
 
-#[allow(dead_code)]
 /// Install the AppStream catalog to the local swcatalog directory.
 /// GNOME Software reads from `~/.local/share/swcatalog/xml/`.
 pub fn install_catalog(db: &Database) -> Result<PathBuf, AppStreamError> {
@@ -484,7 +482,6 @@ pub fn install_catalog(db: &Database) -> Result<PathBuf, AppStreamError> {
     Ok(catalog_path)
 }
 
-#[allow(dead_code)]
 /// Remove the AppStream catalog from the local swcatalog directory.
 pub fn uninstall_catalog() -> Result<(), AppStreamError> {
     let catalog_path = dirs::data_dir()
@@ -501,7 +498,6 @@ pub fn uninstall_catalog() -> Result<(), AppStreamError> {
     Ok(())
 }
 
-#[allow(dead_code)]
 /// Check if the AppStream catalog is currently installed.
 pub fn is_catalog_installed() -> bool {
     let catalog_path = dirs::data_dir()
@@ -515,7 +511,6 @@ pub fn is_catalog_installed() -> bool {
 
 // --- Utility functions ---
 
-#[allow(dead_code)]
 fn make_component_id(name: &str) -> String {
     name.chars()
         .map(|c| if c.is_alphanumeric() || c == '-' || c == '.' { c.to_ascii_lowercase() } else { '_' })
@@ -524,7 +519,6 @@ fn make_component_id(name: &str) -> String {
         .to_string()
 }
 
-#[allow(dead_code)]
 fn xml_escape(s: &str) -> String {
     s.replace('&', "&amp;")
         .replace('<', "&lt;")
@@ -536,7 +530,6 @@ fn xml_escape(s: &str) -> String {
 // --- Error types ---
 
 #[derive(Debug)]
-#[allow(dead_code)]
 pub enum AppStreamError {
     Database(String),
     Io(String),